From eead2535d93aa85ed48e361ecb8d86b274ad5e5a Mon Sep 17 00:00:00 2001 From: James Cook Date: Thu, 21 Jul 2022 16:02:41 +0100 Subject: [PATCH] fix: use from instead of fromDate for consistancy --- src/baseClient.ts | 2 ++ src/types.ts | 14 +++++++++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/src/baseClient.ts b/src/baseClient.ts index cf7202a..06edc80 100644 --- a/src/baseClient.ts +++ b/src/baseClient.ts @@ -155,6 +155,8 @@ export class ClasschartsClient { options?.fromDate && params.append("from", String(options?.fromDate)); options?.toDate && params.append("to", String(options?.toDate)); + options?.from && params.append("from", String(options?.from)); + options?.to && params.append("to", String(options?.to)); const data: Array = await this.makeAuthedRequest( this.API_BASE + "/homeworks/" + this.studentId + "?" + params.toString(), { diff --git a/src/types.ts b/src/types.ts index f024057..933e2be 100644 --- a/src/types.ts +++ b/src/types.ts @@ -109,13 +109,21 @@ export interface GetHomeworkOptions { */ displayDate?: DisplayDate; /** - * From date, in format YYYY-MM-DD + * @deprecated Use "from" instead */ fromDate?: string; /** - * To date, in format YYYY-MM-DD + * @deprecated Use "to" instead */ toDate?: string; + /** + * From date, in format YYYY-MM-DD + */ + from?: string; + /** + * To date, in format YYYY-MM-DD + */ + to?: string; } export interface ValidatedHomeworkAttachment { id: number; @@ -335,4 +343,4 @@ export interface AttendanceDate { }; } -export type AttendanceResponse = Array>; \ No newline at end of file +export type AttendanceResponse = Array>;