feat: parent client tests & consistant error messages (#37)

src/core/parentClient.ts

@@ -26,6 +26,7 @@ export class ParentClient extends BaseClient {
    */
   async login(): Promise<void> {
     if (!this.email) throw new Error("Email not provided");
+    if (!this.password) throw new Error("Password not provided");
     const formData = new URLSearchParams();
     formData.append("_method", "POST");
     formData.append("email", this.email);
@@ -42,11 +43,9 @@ export class ParentClient extends BaseClient {
       redirect: "manual",
     });
     if (response.status != 302 || !response.headers.has("set-cookie")) {
+      await response.body?.cancel(); // Make deno tests happy by closing the body, unsure whether this is needed for the actual library
       throw new Error(
-        "Unauthenticated: ClassCharts returned an error: " +
+        "Unauthenticated: ClassCharts didn't return authentication cookies",
-          response.status +
-          " " +
-          response.statusText,
       );
     }
 

src/core/parentClient_test.ts

@@ -0,0 +1,35 @@
+import { assertRejects } from "~/deps_dev.ts";
+import { ParentClient } from "~/src/core/parentClient.ts";
+
+Deno.test("Throws when no email is provided", async () => {
+  const client = new ParentClient("", "password");
+  await assertRejects(
+    async () => {
+      await client.login();
+    },
+    Error,
+    "Email not provided",
+  );
+});
+
+Deno.test("Throws when no password is provided", async () => {
+  const client = new ParentClient("email", "");
+  await assertRejects(
+    async () => {
+      await client.login();
+    },
+    Error,
+    "Password not provided",
+  );
+});
+
+Deno.test("Throws with invalid username and password", async () => {
+  const client = new ParentClient("invalid", "invalid");
+  await assertRejects(
+    async () => {
+      await client.login();
+    },
+    Error,
+    "Unauthenticated: ClassCharts didn't return authentication cookies",
+  );
+});