From 0adb90390f436b6adb2e59cdc49da4c2f8e58b27 Mon Sep 17 00:00:00 2001
From: veloii <85405932+veloii@users.noreply.github.com>
Date: Fri, 15 Sep 2023 18:46:38 +0100
Subject: [PATCH] fix: attendance typing && expose full attendance response
 object

---
 src/core/baseClient.ts |  2 +-
 src/types.ts           | 35 ++++++++++++++++++++++-------------
 2 files changed, 23 insertions(+), 14 deletions(-)

diff --git a/src/core/baseClient.ts b/src/core/baseClient.ts
index 1a9043e..8ba0286 100644
--- a/src/core/baseClient.ts
+++ b/src/core/baseClient.ts
@@ -300,6 +300,6 @@ export class BaseClient {
           method: "GET",
         },
       )
-    ).data;
+    );
   }
 }
diff --git a/src/types.ts b/src/types.ts
index a60ff89..14d1a71 100644
--- a/src/types.ts
+++ b/src/types.ts
@@ -412,17 +412,26 @@ export interface GetAttendanceOptions {
   to: string;
 }
 
-export interface AttendanceDate {
-  AM: {
-    code: string;
-    status: "present" | "ignore";
-    late_minutes: number;
-  };
-  PM: {
-    code: string;
-    status: "present" | "ignore";
-    late_minutes: number;
-  };
+export interface AttendancePeriod {
+  code: string;
+  status: "present" | "ignore";
+  late_minutes: number;
+  lesson_name?: string;
+  room_name?: string;
 }
-// TODO: Update typings to include meta response. Currently not possible since I don't have access
-export type AttendanceResponse = Record<string, AttendanceDate>[];
+
+export interface AttendanceMeta {
+  dates: string[];
+  sessions: string[];
+  start_date: string;
+  end_date: string;
+  percentage: string;
+  percentage_since_august: string;
+}
+
+export type AttendanceData = Record<string, Record<string, AttendancePeriod>>;
+
+export type AttendanceResponse = ClassChartsResponse<
+  AttendanceData,
+  AttendanceMeta
+>;